Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass timeout param to request.js #27

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/client.js
Original file line number Diff line number Diff line change
@@ -42,11 +42,12 @@ function getErrorMessages(responseBody) {
}
}
class Client {
constructor(apiKey, baseUrl) {
constructor(apiKey, baseUrl, timeout) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making this change. This is great. Could you change this to be an optional config object? That just future proofs this method in case we have additional configuration needs.

Suggested change
constructor(apiKey, baseUrl, timeout) {
constructor(apiKey, baseUrl, { timeout } = {}) {

Then later:

this.requestConfig = { timeout };

And finally:

_jsonRequest(method, path, params) {
    return this._wrap({
      method: method,
      url: `${this.baseUrl}${path}`,
      json: params,
      auth: {
        bearer: this.apiKey
      },
      headers: {
        'X-Swiftype-Client': this.clientName,
        'X-Swiftype-Client-Version': this.clientVersion,
        'Content-Type': 'application/json'
      },
      { ...this.requestConfig }
    })
  }

this.apiKey = apiKey
this.clientName = 'elastic-app-search-node'
this.clientVersion = packageJson.version
this.baseUrl = baseUrl
this.timeout = timeout
}

get(path, params) {
@@ -74,6 +75,7 @@ class Client {
method: method,
url: `${this.baseUrl}${path}`,
json: params,
timeout: this.timeout,
auth: {
bearer: this.apiKey
},