Add stop words to Meili search index #1307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filtering out very common words that carry basically no information improves indexing performance, shrinks the index and most importantly: helps with the problem that searching for common words results in tons of matches in subtitles and such. This doesn't completely solve the latter problem though. And using stop words also makes things worse unfortunately: especially in phrase search, the highlighting is broken and might confuse users. Phrase search still kind of works but from reading the docs, I think with stop search "the" and "a", searching for "foo the bar" will also find documents with the text "foo a bar". So it's not really clear yet whether we want that at all. Maybe Meili needs to improve first. Or we never send the stop words to Meili and only use them to filter some stuff manually?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering out very common words that carry basically no information improves indexing performance, shrinks the index and most importantly: helps with the problem that searching for common words results in tons of matches in subtitles and such. This doesn't completely solve the latter problem though. And using stop words also makes things worse unfortunately: especially in phrase search, the highlighting is broken and might confuse users. Phrase search still kind of works but from reading the docs, I think with stop search "the" and "a", searching for "foo the bar" will also find documents with the text "foo a bar".
So it's not really clear yet whether we want that at all. Maybe Meili needs to improve first. Or we never send the stop words to Meili and only use them to filter some stuff manually?