Add config to lock video ACLs to their series #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
With this enabled, event ACLs can't be edited and will generally be determined by their series.
The search series view knows about read and write roles, but they are hex encoded. In order to display the correct ACL including labels for user names and groups, they need to be decoded and processed into the right data structure first. Fortunately, there are already functions for both decoding and processing/formatting ACLs.
The backend serves these ACLs as arrays of objects holding role, actions and info values. The frontend ACL editor needs this as a map with role as key and the other two props as values. This translation of array to map was already being done in a few different places and I was about to add another instance. At that point I think it's ok to just put this logic in a reusable function.
And then also disable ACL editing and attachment.
owi92
force-pushed
the
acl-upload-config
branch
from
3d53a9f to
119ad94
Compare
github-actions
bot
removed
the
status:conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will disable ACL editing for the uploader and the ACL UI when the video is part of a series.
Uploaded videos will then adopt the ACL of that series.
This needs to be configured with
lock_acl_to_series, the default for this isfalse.Closes #1006