Update backend dependencies #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just boring code adjustments, mostly imports. But this is a nice update as it gets rid of the `isahc` dependency, pruning our dependency tree a bit. The `isahc` and `libz-sys` entries in the Cargo.toml were just to control how indirect dependencies were getting linked and are not necessary anymore.
In elan-ev#546 I configured dependencies to avoid dynamically linking libssl and libz. I just checked again after the Meili update and noticed that those library are again linked dynamically. I think this has to do with me adding `reqwest` as dependencies without disabling default features. With this commit, libssl and libz are again not dynamically linked.
This gets rid of some duplicate dependencies (with two different versions). The new rustls version uses aws-lc-rs as default crypto provider. But since many other dependencies still use ring, I configured rustls to keep using ring as well. We might want to switch in the future. No idea.
LukasKalbertodt
force-pushed
the
backend-updates
branch
from
86d6c00 to
c82a279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also shrink the dependency tree a bit, for example getting rid of
syn 1.xandisahc, as well as duplicate versions of ring and rustls.This is probably the last dependency update before 3.0 so that we have a bit of time to test this still.