-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make event ACL editable via Tobira #1272
Conversation
It TRIGGERS the republish-metadata workflow? Automatically? No additional action needed? Thank you! |
Yes, correct. Though that might still fail, or take some time. So tldr: In a perfect world, there's no additional action needed ;) |
Ole, is https://pr1272.tobira.opencast.org/ still the deployment I should be looking at? If so, I have two minor (!) remarks:
|
Yes. Thank you for the feedback, I think these are good points. Will change accordingly. |
7a3e745
to
faa8d96
Compare
faa8d96
to
5ccb07d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
5ccb07d
to
b6a45bd
Compare
b6a45bd
to
cce8143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this will add a big and long awaited feature! Just a bunch of notes, as far as I remember all should be pretty easy to fix.
cce8143
to
36a64d0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Doing this whenever I spot some.
36a64d0
to
a2545d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes, did not yet test again. It also sounded like you still want to comment in the preview
role stuff, so i expect I will do another short review round anyway.
a2545d6
to
b1e9e72
Compare
I addressed your latest comments. Regarding What I did do, now that If you want to test this locally, to see if preview and custom roles will stick around:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thing, but I also still need to think about the unresolved comments from my first review.
This adds a mutation that will send a PUT request to Opencast to update the acl of a given event. When the request responds with 204, it is considered successful and the updated acl is stored in Tobira's DB, without waiting for sync with OC. That allows us to pretend that things are happening much faster than they do in actuality, as Opencast needs to run the "republish metadata" workflow in order to propagate these changes back to Tobira. There were some discussions and efforts to change how that is done in Opencast, but the proposed changes didn't make the cut yet. Once that or sth similar happens, we should also adapt the mechanism implemented in this commit.
This adds the necessary changes for the interface to commit the mutation added in the previous commit. Also fixes some minor UX issues.
So far this is only needed for republishing metadata in case of acl updates. We might need this in other places, so I made a dedicated function for it. Of course we might also remove it again, if future Opencast changes make it redundant. We'll see.
Not sure if the default should be `true` or `false` for this.
This endpoint allows us to check whether there are any workflows running in Opencast for an event. Also added are error handling and blocking of acl editing based on that check.
b1e9e72
to
9784132
Compare
This comment has been minimized.
This comment has been minimized.
This changes the overall error component to accept ReactNodes instead of just strings as error cause. With this, we can pass it any element, including the i18next `<Trans>` component, which is needed to include most html tags in the error.
9784132
to
96ed8fe
Compare
🚨🚨🚨 This PR changes APIs used by the Opencast Admin UI integration 🚨🚨🚨
|
This will allow users to update event ACL in Opencast via Tobira. Doing so will trigger the
republish-metadata
workflow, so the changes will be propagated to all publications.Closes #1264
can be reviewed commit by commit