Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linters #2

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Update linters #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ansible_lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: install dependencies
run: pip3 install ansible ansible-lint yamllint

- name: lint playbook
run: yamllint -c .yamllint . && ansible-lint
- run: yamllint --strict -c .yamllint .

- run: ansible-lint
8 changes: 8 additions & 0 deletions .yamllint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ extends: default

rules:
line-length: disable
comments:
min-spaces-from-content: 1
comments-indentation: false
braces:
max-spaces-inside: 1
octal-values:
forbid-implicit-octal: true
forbid-explicit-octal: true

ignore: |
venv/
Expand Down
6 changes: 3 additions & 3 deletions tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- name: Allow all internal communication (IPv4)
when: opencast_firewall_ipv4
ansible.builtin.firewalld:
ansible.posix.firewalld:
source: "{{ lookup('community.general.dig', item) }}"
zone: trusted
permanent: true
Expand All @@ -16,7 +16,7 @@

- name: Allow all internal communication (IPv6)
when: opencast_firewall_ipv6
ansible.builtin.firewalld:
ansible.posix.firewalld:
source: "{{ lookup('community.general.dig', item, 'qtype=AAAA') }}"
zone: trusted
permanent: true
Expand All @@ -26,7 +26,7 @@

- name: Allow https
when: inventory_hostname in opencast_firewall_http_hosts
ansible.builtin.firewalld:
ansible.posix.firewalld:
service: "{{ item }}"
permanent: true
immediate: true
Expand Down