Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#16] Reorganization and refactoring #21

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

orecham
Copy link
Contributor

@orecham orecham commented Dec 21, 2024

Notes for Reviewer

  1. Clearly separate code for:
    1. RMW API
    2. Implementation details
  2. Naming convention to distinguish RMW and Impl types
  3. Fix naming of BasicTypes demo nodes

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (rmw-iox2-123-implement-graph-api)
  • Commit messages have the issue ID ([#123] Add posix ipc example)
  • Tests exist for new behavior
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #16

@orecham orecham self-assigned this Dec 21, 2024
@orecham orecham merged commit cda4d68 into ekxide:main Dec 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscellaneous code cleanliness tasks
1 participant