Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc dependencies and supported Python runtime to publish latest doc updates #8119

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

bryantbiggs
Copy link
Member

Description

  • Update docs site dependencies to latest
  • Update Netlify Python runtime to supported runtime (Python 3.8 is EOL)
  • Update docs site CDN JS versions to more current versions

The current site is not updating - possibly due to Netlify not publishing updates due to the unsupported Python version specified (not 100% certain, someone would need to log in to Netlify to check). If you look at the current site banner versus running locally with these changes - you'll see the banner running locally shows notices for Auto Mode and Hybrid Nodes which were launched at 0.195.0 for re:Invent. In addition, the reference schema does not change the fields for Auto Mode or Hybrid Node.

Current banner:
image

Banner running locally with these changes - notice Auto Mode and Hybrid Node notices:
image

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@bryantbiggs
Copy link
Member Author

bryantbiggs commented Jan 9, 2025

preview site looks good https://deploy-preview-8119--eksctl.netlify.app/

@TiberiuGC TiberiuGC added the kind/docs User documentation label Jan 9, 2025
@bryantbiggs
Copy link
Member Author

Pushed a fix for link checker which seems to have been failing for quite some time https://github.com/eksctl-io/eksctl/actions/workflows/link-checker.yaml

@TiberiuGC TiberiuGC changed the title docs: Update doc dependencies and supported Python runtime to publish latest doc updates Update doc dependencies and supported Python runtime to publish latest doc updates Jan 9, 2025
@TiberiuGC TiberiuGC enabled auto-merge (squash) January 9, 2025 18:44
@TiberiuGC TiberiuGC merged commit 738177d into eksctl-io:main Jan 9, 2025
11 checks passed
@bryantbiggs bryantbiggs deleted the fix/docs branch January 9, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add autoModeConfig to schema
2 participants