feat(ec2-network-interfaces): add description property #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apgrucza
force-pushed
the
ec2-network-interface-description
branch
from
8b409ed to
04793e7
Compare
apgrucza
changed the title
|
Apologies for the delay, not sure why I'm not seeing the PR notifications. |
|
@apgrucza I appreciate your PR but I'm going to have to close it in favor of a PR i'm putting together but I've incorporated your change. Typically I would have preferred to pull your commit over but I had already changed up the resource to the new struct tagging format as such it would not apply cleanly. See #529 |
|
Thanks @ekristen but unfortunately you missed the line that actually sets the Description field |
|
Shoot, I did have it. Well if you want to submit a fix PR. I'll approve and get it merged. |
|
Sure, see #531 |
|
Thanks sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
EC2NetworkInterfaceto be filtered byDescription. The reason for this change is explained below.Amazon MSK automatically creates network interfaces (ENIs) in the customer account, and if these are deleted then you lose the ability to connect to the MSK cluster. There is no way to recreate these ENIs apart from deleting and recreating the cluster. These ENIs are untagged but have a Description property in the format
DO NOT DELETE - Amazon MSK network interface for cluster <cluster_arn>.. We can use this property to prevent aws-nuke deleting these critical resources.Fixes #528