Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bedrockagent): set Bedrock Datasource data deletion policy to RETAIN before deleting it #432

Merged

Conversation

npellegrin
Copy link
Contributor

Closes #431

@npellegrin
Copy link
Contributor Author

Output with the implemented fix.
The failed datasource previously on DELETE_UNSUCCESSFUL status can be properly deleted.

us-east-1 - BedrockKnowledgeBase - 5OZDA2VLM7 - [ID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-idsv5", Status: "DELETE_UNSUCCESSFUL"] - would remove
us-east-1 - BedrockDataSource - QMTF2MTCVF - [ID: "QMTF2MTCVF", KnowledgeBaseID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-40k4o-data-source", Status: "DELETE_UNSUCCESSFUL"] - would remove
Scan complete: 2 total, 2 nukeable, 0 filtered.

Do you really want to nuke the account with the ID 571875759811 and the alias 'icelab-account60'?
Do you want to continue? Enter account alias to continue.
> icelab-account60

us-east-1 - BedrockKnowledgeBase - 5OZDA2VLM7 - [ID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-idsv5", Status: "DELETE_UNSUCCESSFUL"] - triggered remove
us-east-1 - BedrockDataSource - QMTF2MTCVF - [ID: "QMTF2MTCVF", KnowledgeBaseID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-40k4o-data-source", Status: "DELETE_UNSUCCESSFUL"] - triggered remove

Removal requested: 2 waiting, 0 failed, 0 skipped, 0 finished

us-east-1 - BedrockKnowledgeBase - 5OZDA2VLM7 - [ID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-idsv5", Status: "DELETE_UNSUCCESSFUL"] - waiting
us-east-1 - BedrockDataSource - QMTF2MTCVF - [ID: "QMTF2MTCVF", KnowledgeBaseID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-40k4o-data-source", Status: "DELETE_UNSUCCESSFUL"] - waiting

Removal requested: 2 waiting, 0 failed, 0 skipped, 0 finished

us-east-1 - BedrockKnowledgeBase - 5OZDA2VLM7 - [ID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-idsv5", Status: "DELETE_UNSUCCESSFUL"] - removed
us-east-1 - BedrockDataSource - QMTF2MTCVF - [ID: "QMTF2MTCVF", KnowledgeBaseID: "5OZDA2VLM7", Name: "knowledge-base-quick-start-40k4o-data-source", Status: "DELETE_UNSUCCESSFUL"] - removed

Removal requested: 0 waiting, 0 failed, 0 skipped, 2 finished

Nuke complete: 0 failed, 0 skipped, 2 finished.

@npellegrin npellegrin changed the title fix(bedrockagent) set Bedrock Datasource data deletion policy to RETAIN before deleting it fix(bedrockagent): set Bedrock Datasource data deletion policy to RETAIN before deleting it Nov 24, 2024
@npellegrin npellegrin force-pushed the bug/bedrock-agent-datasource-stuck branch from e9b2034 to 4bf6a44 Compare November 24, 2024 23:34
@npellegrin npellegrin force-pushed the bug/bedrock-agent-datasource-stuck branch from 4bf6a44 to cca02de Compare November 24, 2024 23:38
@npellegrin
Copy link
Contributor Author

CI linter fixed, ready for review ❤️

@ekristen ekristen merged commit 49a6740 into ekristen:main Nov 25, 2024
4 checks passed
@ekristen
Copy link
Owner

🎉 This PR is included in version 3.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ekristen
Copy link
Owner

And just like that, it's released :) thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bedrock Agent Datasource: DELETE_UNSUCCESSFUL when data is already deleted
2 participants