Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial release #1

Merged
merged 3 commits into from
Jan 9, 2025
Merged

feat: initial release #1

merged 3 commits into from
Jan 9, 2025

Conversation

wkillerud
Copy link
Contributor

Goal is to make using Eik with Vite slightly more ergonomic than with the Rollup plugin.

Similar to viteik, but less opinionated in the output department.

wkillerud
wkillerud commented Dec 17, 2024
View reviewed changes
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
tap-snapshots/test/plugin.js.test.cjs Outdated Show resolved Hide resolved
wkillerud
wkillerud commented Dec 18, 2024
View reviewed changes
Copy link
Contributor Author

@wkillerud wkillerud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots match the ones from the rollup plugin, though with a different format since we use the native runner instead of tap.

@trygve-lie
Copy link

Cool. Great stuff.

Though; The Eik Rollup plugin is a small abstraction on top of a generic import mapping plugin. So this is an abstraction on top of another abstraction. The Eik Rollup plugin is pretty small and I wonder if its worth duplicating the Eik Rollup plugin in here with the additional Vite stuff just to avoid the abstraction on top of an abstraction layers.

Thoughts?

@wkillerud
Copy link
Contributor Author

I think it's fine going via the Rollup plugin as long as Vite uses Rollup under the hood.

@wkillerud wkillerud merged commit 9fd0208 into main Jan 9, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
25c7100 
# 1.0.0 (2025-01-09)

### Features

* initial release ([#1](#1)) ([9fd0208](9fd0208))
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wkillerud
Copy link
Contributor Author

Docs: eik-lib/eik-lib.github.io@d35325c

@wkillerud wkillerud deleted the initial branch January 9, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkillerud @trygve-lie