Update to QUDT v2.1.4 #2
Conversation
|
@gnmerritt Sorry I missed this last year. I'm surprised someone found the library! If you built anything from it I'd love to see. |
|
@gnmerritt I added CI, which includes isort and black, so there will be some git conflicts. These can be dealt with by attempting a rebase, and when the conflict occurs, check out the original commit in this branch via |
| @@ -5,7 +5,8 @@ | |||
| "rdf": "http://www.w3.org/1999/02/22-rdf-syntax-ns#", | |||
| "rdfs": "http://www.w3.org/2000/01/rdf-schema#", | |||
| "skos": "http://www.w3.org/2004/02/skos/core#", | |||
| "xsd": "http://www.w3.org/2001/XMLSchema#" | |||
| "xsd": "http://www.w3.org/2001/XMLSchema#", | |||
| "kind": "http://qudt.org/vocab/quantitykind/" | |||
There was a problem hiding this comment.
Small request, can you keep lists in alphabetical order?
|
I noticed a list that could be alphabetized. But aside from that everything here looks good. @gnmerritt are you willing to rebase? |
|
Yeah I'll be able to get to it after the holidays |
|
@gnmerritt I fixed the rebase conflicts on my end so there's nothing blocking this PR. What's its current state? |
|
ahh sorry, didn't realize I had the PR up from my |
|
OK, no worries! Do you want to close this to avoid the noise here? Feel free to re-open if life brings you bountiful time. |
Hi - thanks for the great QUDT bindings!
We're using them with a newer version of the QUDT ontology, and so here's a PR with our changes. There are currently a number of disabled unit tests for units that are defined outside QUDT (micromolar, etc) that I unfortunately don't have the hours to put against fixing up. That said, I think this branch is a good starting point for the ontology version upgrade so I wanted to at least start a discussion about potentially merging it.
Note: this PR also updates
frozendictto make it safe for Python 3.9+ -an old import pattern is deprecated and being discontinued so I believe the package as-is will be broken.