Environment: make identifier optional

[andmat900]

Applicable Issues

• Identifier may be an empty string #266

Description of the Change

This change introduces handling of environment requests and environments that aren't bound to suite id/testrun and thus have no identifier attribute. This allows creating EnvironmentRequest / Environment objects without a testrun using Kubernetes API directly.

Alternate Designs

Possible Drawbacks

Sign-off

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Andrei Matveyeu, [email protected]

[t-persson]

The issue that you are refering to does not say anything about the environment controller or spec.
The issue is for the environmentrequest.spec.identifier which has omitempty and it shall be handled in the environmentrequest controller.

[andmat900]

The issue that you are refering to does not say anything about the environment controller or spec. The issue is for the environmentrequest.spec.identifier which has omitempty and it shall be handled in the environmentrequest controller.

Your issue does not say where/how it should be handled.

When no identifier is given in environment request label, are you suggesting to set a zero UUID identifier here?

etos/internal/controller/environmentrequest_controller.go

Line 235 in a2d6e0d

"etos.eiffel-community.github.io/id": environmentrequest.Spec.Identifier, // TODO: omitempty

If not, how can this handling be limited to environmentrquest controller?

[t-persson]

The issue that you are refering to does not say anything about the environment controller or spec. The issue is for the environmentrequest.spec.identifier which has omitempty and it shall be handled in the environmentrequest controller.

Your issue does not say where/how it should be handled.

When no identifier is given in environment request label, are you suggesting to set a zero UUID identifier here?

etos/internal/controller/environmentrequest_controller.go

Line 235 in a2d6e0d

"etos.eiffel-community.github.io/id": environmentrequest.Spec.Identifier, // TODO: omitempty

If not, how can this handling be limited to environmentrquest controller?

The issue refers to this TODO: https://github.com/eiffel-community/etos/blob/main/internal/controller/environmentrequest_controller.go#L235 which states that this parameter may be omitted when creating an environmentrequest as per this line https://github.com/eiffel-community/etos/blob/main/api/v1alpha1/environmentrequest_types.go#L56 . This means that the environmentrequest_controller must handle the cases where it is empty.

Adding omitempty to other parameters is not something that should be done in this case.

[andmat900]

When no identifier is given in environment request label, are you suggesting to set a zero UUID identifier here?

etos/internal/controller/environmentrequest_controller.go

Line 235 in a2d6e0d

"etos.eiffel-community.github.io/id": environmentrequest.Spec.Identifier, // TODO: omitempty

If not, how can this handling be limited to environmentrquest controller?

Please clarify these two questions.

[t-persson]

When no identifier is given in environment request label, are you suggesting to set a zero UUID identifier here?

etos/internal/controller/environmentrequest_controller.go

Line 235 in a2d6e0d

"etos.eiffel-community.github.io/id": environmentrequest.Spec.Identifier, // TODO: omitempty

If not, how can this handling be limited to environmentrquest controller?

Please clarify these two questions.

identifier := environmentrequest.Spec.Identifier
if identifier == "" {
  identifier = string(uuid.NewUUID())
}
environmentrequest.Labels["etos.eiffel-community.github.io/id"] = identifier