Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Serializer support + disabled Symfony serializer #7

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Rastusik
Copy link

@Rastusik Rastusik commented Sep 8, 2017

Hi, I created my own serializer which seems to be 4-5x faster than JMS and Ivory (using json serialization) ... since there is quite a big difference between the mentioned 3 libs and symfony serializer, I disabled the symfony serializer, because it was 100-300x slower then my own serializer and it was quite a pain to wait for the benchmark results.

Is there any other thing I should do before merge? What do you say about these changes?

@goetas
Copy link

goetas commented Nov 14, 2018

I have forked this repo in https://github.com/php-serializers/ivory-serializer-benchmark and created a php-serializers github org.

I invite you to use https://github.com/php-serializers/ivory-serializer-benchmark for benchmarking PHP serializer libraries

I have merged some PR from this repo to the fork, but this PR was looking pretty complex.
Do you mind creating a PR against the fork?

@Rastusik
Copy link
Author

@goetas I'll try, but currently I don't have much time to do this, so I'll just do it later, if you don't mind

@goetas
Copy link

goetas commented Nov 14, 2018

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants