Review fixes

efosamark · Apr 23, 2024 · c7d057f · c7d057f
1 parent bb868c8
commit c7d057f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/source/hex_funcs.hpp b/source/hex_funcs.hpp
@@ -136,11 +136,7 @@ FILE* openFile(const std::string& filePath) {
     return file;
 }
 
-void closeFile(FILE* const file) {
-    fclose(file);
-}
-
-size_t findCustOffset(FILE* const file) {
+long findCustOffset(FILE* const file) {
     const std::vector<std::size_t> dataOffsets = findHexDataOffsetsF(file, "43555354");
     if (dataOffsets.empty()) {
         log("readHexDataAtOffset: data \"%s\" not found.", "CUST");
@@ -149,7 +145,7 @@ size_t findCustOffset(FILE* const file) {
     return dataOffsets[0];
 }
 
-std::string readHexDataAtOffset(FILE* const file, const std::string& hexData, const size_t offsetFromData, size_t length, int custOffset = -1) {
+std::string readHexDataAtOffset(FILE* const file, const std::string& hexData, const size_t offsetFromData, size_t length, long custOffset = -1) {
     // log("Entered readHexDataAtOffset");
 
     if (!file) {

diff --git a/source/ini_funcs.hpp b/source/ini_funcs.hpp
@@ -587,7 +587,7 @@ std::string readIniValue(const std::string& filePath, const std::string& section
     return ""; // Key not found
 }
 
-std::vector<std::vector<int>> parseIntIniData (std::string input, bool skipFirstItem = true) {
+std::vector<std::vector<int>> parseIntIniData (const std::string input, bool skipFirstItem = true) {
     // Remove outer brackets
     input = input.substr(6, input.length() - 3);
 

diff --git a/source/main.cpp b/source/main.cpp
@@ -792,7 +792,7 @@ class SubMenu : public tsl::Gui {
     ~SubMenu() {}
 
     FILE* kipFile = nullptr;
-    size_t custOffset;
+    long custOffset;
 
     auto addSliderItem(auto& sliderOption)
     {
@@ -1257,7 +1257,7 @@ class SubMenu : public tsl::Gui {
         }
 
         if (kipFile) {
-            closeFile(kipFile);
+            fclose(kipFile);
             kipFile = nullptr;
         }
         constexpr int lineHeight = 20;  // Adjust the line height as needed