Merge pull request #117 from edx/jsa/banner-image-url-keys

Fix banner image url keys in programs API response
edx · Apr 6, 2016 · 776503e · 776503e
2 parents 40ab973 + 39bfd76
commit 776503e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/programs/apps/api/serializers.py b/programs/apps/api/serializers.py
@@ -276,7 +276,7 @@ def get_banner_image_urls(self, instance):
         url_items = instance.banner_image.resized_urls.items()
         # in case MEDIA_URL does not include scheme+host, ensure that the URLs are absolute and not relative
         url_items = [[size, self.context['request'].build_absolute_uri(url)] for size, url in url_items]
-        return {'{}x{}'.format(*size): url for size, url in url_items}
+        return {'w{}h{}'.format(*size): url for size, url in url_items}
 
     def create(self, validated_data):
         """

diff --git a/programs/apps/api/v1/tests/test_views.py b/programs/apps/api/v1/tests/test_views.py
@@ -345,7 +345,7 @@ def assert_correct_banner_image_urls(self, url_prepend=''):
         self.assertEqual(response.status_code, 200)
 
         expected_urls = {
-            '{}x{}'.format(*size): '{}{}__{}x{}.jpg'.format(url_prepend, program.banner_image.url, *size)
+            'w{}h{}'.format(*size): '{}{}__{}x{}.jpg'.format(url_prepend, program.banner_image.url, *size)
             for size in program.banner_image.field.sizes
         }
         self.assertEqual(response.data[u'banner_image_urls'], expected_urls)