fix: Bugs with navigation and UI improvements on EditProfile #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle onBackPressed - Invalidate `Done` button on data change on EditProfile - Add Loader while hitting API fix: LEARNER-10388
k1rill
reviewed
Jan 27, 2025
| @@ -163,6 +165,17 @@ class EditProfileFragment : Fragment() { | |||
| } | |||
| } | |||
|
|
|||
| private val onBackPressedCallback = object : OnBackPressedCallback(true) { | |||
| override fun handleOnBackPressed() { | |||
| if (viewModel.profileDataChanged) { | |||
There was a problem hiding this comment.
This code is very close to lambda in EditProfileScreen
onBackClick = {
if (it) {
viewModel.setShowLeaveDialog(true)
} else {
viewModel.setShowLeaveDialog(false)
requireActivity().supportFragmentManager.popBackStackImmediate()
}
},
maybe we can create a separate method from this?
HamzaIsrar12
requested changes
Jan 27, 2025
HamzaIsrar12
approved these changes
Jan 27, 2025
k1rill
approved these changes
Jan 29, 2025
HamzaIsrar12
approved these changes
Jan 29, 2025
farhan-arshad-dev
pushed a commit
that referenced
this pull request
Jan 29, 2025
fix: Bugs with navigation and UI improvements on EditProfile - Handle onBackPressed - Invalidate `Done` button on data change on EditProfile - Add Loader while hitting API fix: LEARNER-10388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Donebutton on data change on EditProfilefix: LEARNER-10388