Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue to load the video through chrome-cast device #83

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: issue to load the video through chrome-cast device #83

merged 1 commit into from
Jan 20, 2025

Conversation

farhan-arshad-dev
Copy link
Member

Description

  • Fix the issue by loading the video through the Chrome-cast device.
  • This issue arises due to race conditions between the setSessionAvailabilityListener and castPlayer initialization.

Steps to Reproduce:

  • Load the edX app
  • Connect the mobile device with the chrome-cast
  • After the device is connected successfully, try to play any video through chrome-cast
  • Notice the video will play on the device instead of the LCD

Jira: LEARNER-10350

@farhan-arshad-dev farhan-arshad-dev self-assigned this Jan 15, 2025
@omerhabib26 omerhabib26 reopened this Jan 16, 2025
HamzaIsrar12
HamzaIsrar12 approved these changes Jan 17, 2025
View reviewed changes
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified an issue where the Cast functionality stops working when users change the device orientation. While this is a significant issue, it will be addressed with the Native Player revamp PR, which is still in progress.

For now, we can approve and merge this code to ensure the basic Cast functionality works.

@farhan-arshad-dev farhan-arshad-dev merged commit 0368c3b into 2U/develop Jan 20, 2025
6 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the 2U/farhan_ar/LEARNER-10350 branch January 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamzaIsrar12 HamzaIsrar12 HamzaIsrar12 approved these changes

@k1rill k1rill k1rill approved these changes

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

Assignees

@farhan-arshad-dev farhan-arshad-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@farhan-arshad-dev @k1rill @HamzaIsrar12 @omerhabib26