-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add dropdown menu on NotificationsInboxFragment #80
base: 2U/develop
Are you sure you want to change the base?
Conversation
- Added ability to mark all the notifications as read at once - User can now navigate to notification preferences screen from inbox fix: LEARNER-10341
ef39188
to
8561166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits only.
...ons/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxFragment.kt
Outdated
Show resolved
Hide resolved
notifications/src/main/java/org/openedx/notifications/data/model/NotificationsMenuType.kt
Outdated
Show resolved
Hide resolved
...ns/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxViewModel.kt
Outdated
Show resolved
Hide resolved
...ns/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxViewModel.kt
Outdated
Show resolved
Hide resolved
...ns/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxViewModel.kt
Outdated
Show resolved
Hide resolved
...ns/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsInboxViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor refactoring only...
...ications/src/main/java/org/openedx/notifications/presentation/inbox/NotificationsMenuType.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
fix: LEARNER-10341