Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notifications indicator on the learn tab #75

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

farhan-arshad-dev
Copy link
Member

@farhan-arshad-dev farhan-arshad-dev commented Dec 20, 2024

Description

LEARNER-10347

  • Introduce a notifications icon on the Learn tab that can inform the learner about unread notifications.
  • When there is >0 notification count for "discussion" app in the Notifications count API, the learner should see the unread notifications icon on the learn tab.
  • When there is 0 notification count for "discussion" app in the Notifications count API, the learner should see the no unread notifications icon on the learn tab.
  • Update the notification count during pull-to-refresh action.

@farhan-arshad-dev farhan-arshad-dev changed the base branch from 2U/develop to 2U/farhan_ar/notifications_module December 20, 2024 12:30
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall. Some minor nits only.

Base automatically changed from 2U/farhan_ar/notifications_module to 2U/develop December 24, 2024 06:15
@farhan-arshad-dev farhan-arshad-dev force-pushed the 2U/farhan_ar/LEARNER-10347 branch from bd7283d to db04369 Compare December 24, 2024 07:47
Copy link
Collaborator

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@HamzaIsrar12 HamzaIsrar12 merged commit 00280ec into 2U/develop Dec 24, 2024
3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the 2U/farhan_ar/LEARNER-10347 branch December 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants