Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide google auth option, if GoogleApi doesn't available on device #72

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

k1rill
Copy link
Collaborator

@k1rill k1rill commented Dec 11, 2024

Some devices are coming with no GooglePlayServices installed on it, so If you will try to sign in or sign up using google auth option you will get an error.

It this PR I added option to hide Google auth button if GooglePlayServices doesn't available on device.

@k1rill k1rill changed the title Hhide google auth option, if GoogleApi doesn't available on device Hide google auth option, if GoogleApi doesn't available on device Dec 11, 2024
@HamzaIsrar12 HamzaIsrar12 self-requested a review December 17, 2024 09:42
Copy link

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@k1rill k1rill merged commit f589e54 into edx:2U/develop Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants