Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Subtitle Support for Native Player in Fullscreen Mode #64

Merged
merged 11 commits into from
Nov 19, 2024
Merged

feat: Add Subtitle Support for Native Player in Fullscreen Mode #64

merged 11 commits into from
Nov 19, 2024

Conversation

HamzaIsrar12
Copy link

Description

  • Added CC (Closed Caption) button in fullscreen mode for subtitle control in the native player
  • Subtitle selection persists across orientation changes
  • Subtitles are downloaded and removed in sync with videos
  • Subtitles available for offline playback
  • Different languages supported for subtitles inside and outside the player

Technical Changes:

  • Updated database with migration for subtitle data. Test app by updating from a previous version with downloaded videos to ensure smooth migration.

@HamzaIsrar12
chore: Update Media3 library to version 1.4.1
66b158e 
Fixes: LEARNER-10259
@HamzaIsrar12
chore: Remove custom HLSMediaSource in favor of DefaultMediaSource
fcc7f83 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Add the CC Button in the ExoPlayer view
2c31a7f 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Pass transcripts to VideoFullScreenFragment
b66c257 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Configure MediaItem with subtitles
50e3618 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Retain subtitle on configuration change
c5ee950 
Fixes: LEARNER-10259
@HamzaIsrar12
chore: Sort the subtitle listing in the ExoPlayer
0cd59b9 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Update the video DownloadModel to include transcripts
8171a7d 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Download transcripts along with videos for offline mode
2310f67 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Make the feature compatible with external subtitles
c365ea4 
Fixes: LEARNER-10259
@HamzaIsrar12
feat: Remove transcripts on removing video
07738f7 
Fixes: LEARNER-10259
@HamzaIsrar12 HamzaIsrar12 merged commit 8779f40 into 2U/develop Nov 19, 2024
3 checks passed
@HamzaIsrar12 HamzaIsrar12 deleted the hamza/LEARNER-10259 branch November 19, 2024 10:40
@HamzaIsrar12 HamzaIsrar12 self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan-arshad-dev farhan-arshad-dev farhan-arshad-dev approved these changes

@dixidroid dixidroid dixidroid approved these changes

@k1rill k1rill Awaiting requested review from k1rill

@omerhabib26 omerhabib26 Awaiting requested review from omerhabib26

Assignees

@HamzaIsrar12 HamzaIsrar12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HamzaIsrar12 @dixidroid @farhan-arshad-dev