Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Analytics events improvements & Add missing ones #46

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

HamzaIsrar12
Copy link

@HamzaIsrar12 HamzaIsrar12 commented Sep 4, 2024

Description

I have removed the extra space after the colon in Payment Events, ensuring consistency with the other analytics.

  • Add missing events after the parity with the iOS Platform app.
  • Code improvements to restrict the event triggered against the user action.
  • Fix test cases.

I have removed the extra space after the colon in Payment
Events, ensuring consistency with the other analytics.

Fixes: LEARNER-10192
- `MainDashboard:Learn` & `Learn:My Courses` were sent multiple times on `LearnFragment` resume.

fixes: LEARNER-10192
@farhan-arshad-dev farhan-arshad-dev changed the title fix: Payment Analytics fix: Analytics events improvements & Add missing ones Sep 11, 2024
Copy link

@omerhabib26 omerhabib26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farhan-arshad-dev farhan-arshad-dev merged commit 4220f1e into 2U/develop Sep 12, 2024
4 checks passed
@farhan-arshad-dev farhan-arshad-dev deleted the 2U/hamza/LEARNER-10192 branch September 12, 2024 09:22
@HamzaIsrar12 HamzaIsrar12 self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants