chore: add portal-designer to devstack #82
+67
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huniafatima-arbi
changed the title
huniafatima-arbi
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
from
8c43dbf to
173e049
Compare
huniafatima-arbi
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
from
ef7cb74 to
ae060a1
Compare
huniafatima-arbi
force-pushed
the
huniafatima/add-portal-designer-in-devstack
branch
from
ae060a1 to
66d544a
Compare
Comment on lines
+410
to
+412
| dev.shell.designer: | ||
| docker exec -it edx.devstack.designer env TERM=$(TERM) bash -c '/bin/bash' | ||
|
|
| @@ -31,7 +31,6 @@ services: | |||
| - edxapp_tox:/edx/app/edxapp/edx-platform/.tox | |||
| - edxapp_uploads:/edx/var/edxapp/uploads | |||
| - ${DEVSTACK_WORKSPACE}/src:/edx/src | |||
| - ${PWD}/py_configuration_files/cms.py:/edx/app/edxapp/edx-platform/cms/envs/devstack.py | |||
There was a problem hiding this comment.
Why is this being removed?
| @@ -57,7 +61,6 @@ services: | |||
| - edxapp_uploads:/edx/var/edxapp/uploads | |||
| - ${DEVSTACK_WORKSPACE}/src:/edx/src | |||
| - ${PWD}/py_configuration_files/cms.py:/edx/app/edxapp/edx-platform/cms/envs/devstack.py | |||
| - ${PWD}/py_configuration_files/lms.py:/edx/app/edxapp/edx-platform/lms/envs/devstack.py | |||
There was a problem hiding this comment.
Similar, why is this being removed?
|
|
||
| # Run migrations | ||
| echo -e "${GREEN}Running migrations for ${name}...${NC}" | ||
| docker exec -t edx.devstack.designer bash -c "cd /edx/app/${name}/ && make migrate" |
There was a problem hiding this comment.
you can use docker compose exec with ${name} for a similar command pattern. Also in next commands as well.
Comment on lines
+30
to
+36
| # Provision IDA User in LMS | ||
| echo -e "${GREEN}Provisioning ${name}_worker in LMS...${NC}" | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker manage_user ${name}_worker ${name}[email protected] --staff --superuser" | ||
|
|
||
| # Create the DOT applications - one for single sign-on and one for backend service IDA-to-IDA authentication. | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker create_dot_application --grant-type authorization-code --skip-authorization --redirect-uris 'http://localhost:${port}/complete/edx-oauth2/' --client-id '${name}-sso-key' --client-secret '${name}-sso-secret' --scopes 'user_id' ${name}-sso ${name}_worker" | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker create_dot_application --grant-type client-credentials --client-id '${name}-backend-service-key' --client-secret '${name}-backend-service-secret' ${name}-backend-service ${name}_worker" |
There was a problem hiding this comment.
We can call provison-ida-user.sh script here.
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker create_dot_application --grant-type client-credentials --client-id '${name}-backend-service-key' --client-secret '${name}-backend-service-secret' ${name}-backend-service ${name}_worker" | ||
|
|
||
| # Restart designer app | ||
| docker compose stop designer |
There was a problem hiding this comment.
Shouldn't we restart instead of stopping, as indicated by comment.
| @@ -67,6 +67,8 @@ Instead of a service name or list, you can also run commands like ``make dev.pro | |||
| +------------------------------------+-------------------------------------+----------------+--------------+ | |||
| | `frontend-app-ora-grading`_ | http://localhost:1993 | MFE (React.js) | Extra | | |||
| +------------------------------------+-------------------------------------+----------------+--------------+ | |||
| | `designer`_ | http://localhost:3307 | Python/Django | Extra | | |||
There was a problem hiding this comment.
Wrong port mentioned here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.