Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONIC-704: Add CT discount availed check for outline tab #303

Merged
merged 12 commits into from
Jan 2, 2025
Merged

SONIC-704: Add CT discount availed check for outline tab #303

merged 12 commits into from
Jan 2, 2025

Conversation

NoyanAziz
Copy link
Contributor

@NoyanAziz NoyanAziz commented Nov 27, 2024 •
edited
Loading

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  commerce_coordinator/apps/commercetools
  clients.py
  commerce_coordinator/apps/commercetools/tests
  test_clients.py
  commerce_coordinator/apps/lms
  serializers.py
  views.py 369
  commerce_coordinator/apps/lms/tests
  test_views.py
Project Total  

This report was generated by python-coverage-comment-action

shafqatfarhan
shafqatfarhan approved these changes Dec 27, 2024
View reviewed changes
commerce_coordinator/settings/base.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/views.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/views.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/views.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/views.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/lms/views.py Outdated Show resolved Hide resolved
@NoyanAziz NoyanAziz merged commit 1772b10 into main Jan 2, 2025
8 checks passed
@NoyanAziz NoyanAziz deleted the naziz1/SONIC-704/add-ct-discount-check-for-outline-tab branch January 2, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aht007 aht007 aht007 left review comments

@syedsajjadkazmii syedsajjadkazmii syedsajjadkazmii approved these changes

@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes

@shafqatfarhan shafqatfarhan shafqatfarhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NoyanAziz @shafqatfarhan @abdullahwaheed @syedsajjadkazmii @aht007