fix: update logging message #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mubbsharanwar
force-pushed
the
manwar/SONIC-794
branch
from
7ba2c5e to
cd1e98b
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
update loging message copy by adding exception message for debugging SONIC-794
mubbsharanwar
force-pushed
the
manwar/SONIC-794
branch
from
cd1e98b to
799feb3
Compare
aht007
reviewed
Nov 26, 2024
| @@ -118,8 +120,10 @@ def post(self, url, json, line_item_state_payload, logging_obj, timeout=None): | |||
| sender=self.__class__, | |||
| **fulfill_line_item_state_payload | |||
| ) | |||
| error_message = Json.loads(exc.response.text).get('message') | |||
There was a problem hiding this comment.
The error message is already being logged here. We don't need to modify the logging below IMO as @attiyaIshaque is currently working on improving logging and will be dealing with this too ideally under the scope of her ticket
There was a problem hiding this comment.
In DD logs the error message is missing and we added it.
In the SONIC-794 mentioned that to formate the DD log with the appropriate information.
|
Not needed these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logging message copy by adding an exception message for debugging.
SONIC-794
Merge checklist:
Check off if complete or not applicable:
Post-merge: