Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled exception gracefully and returned proper response #300

Merged

Conversation

abdullahwaheed
Copy link
Contributor

Description

Gracefully handle exception in legacy and CT endpoints for combined order history

SONIC-788

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Unit tests added/updated

Post-merge:

@abdullahwaheed abdullahwaheed force-pushed the abdullahwaheed/handle-order-history-errors-gracefully branch from 1da72a2 to 6f6f6aa Compare November 25, 2024 08:10
Copy link

github-actions bot commented Nov 25, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/frontend_app_ecommerce
  views.py
  commerce_coordinator/apps/frontend_app_ecommerce/tests
  test_views.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval from my side once you add the test.

@abdullahwaheed abdullahwaheed merged commit 2c8885a into main Nov 27, 2024
8 checks passed
@abdullahwaheed abdullahwaheed deleted the abdullahwaheed/handle-order-history-errors-gracefully branch November 27, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants