Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lms_user_id population #280

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

aht007
Copy link
Member

@aht007 aht007 commented Oct 16, 2024

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@aht007 aht007 changed the title fix: fallback to username for user's with no lms_user_id fix: fallback to username for users with no lms_user_id Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  authentication.py
  clients.py
  filters.py
  signals.py
  tasks.py
  commerce_coordinator/apps/commercetools/catalog_info
  edx_utils.py
  utils.py
  commerce_coordinator/apps/commercetools/sub_messages
  signals_delayed.py
  tasks.py
  commerce_coordinator/apps/commercetools/tests
  _test_cases.py
  conftest.py
  test_clients.py
  test_data.py
  test_pipeline.py
  test_signals.py
  test_tasks.py
  test_utils.py
  commerce_coordinator/apps/commercetools/tests/catalog_info
  test_utils.py
  commerce_coordinator/apps/commercetools/tests/sub_messages
  test_signals_delayed.py
  test_tasks.py
  commerce_coordinator/apps/core
  models.py 86-87
  commerce_coordinator/apps/core/tests
  test_models.py
  commerce_coordinator/apps/frontend_app_ecommerce
  views.py
  commerce_coordinator/apps/lms
  tasks.py
  views.py
Project Total  

The report is truncated to 25 files out of 81. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

@aht007 aht007 force-pushed the aht007/SONIC-fix-enrollment-bug branch from 5bb95fa to bddc2a4 Compare October 17, 2024 13:39
commerce_coordinator/apps/core/models.py Outdated Show resolved Hide resolved
@aht007 aht007 changed the title fix: fallback to username for users with no lms_user_id fix: fix lms_user_id population Oct 17, 2024
@aht007 aht007 merged commit 881cda1 into main Oct 17, 2024
9 checks passed
@aht007 aht007 deleted the aht007/SONIC-fix-enrollment-bug branch October 17, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants