Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing lua wrappers #68

Merged
merged 34 commits into from
Aug 16, 2023
Merged

Add missing lua wrappers #68

merged 34 commits into from
Aug 16, 2023

Conversation

edunad
Copy link
Owner

@edunad edunad commented Aug 8, 2023

  • Add string replace
  • Add scripting wrapper
  • Add mod wrapper
  • Fix include not auto-reloading
  • Better lua error check

Closes #64

- Add scripting wrapper
- Add mod wrapper
- Fix include not auto-reloading
- Better lua error check
@github-actions github-actions bot added ⚒️ UTILS RAWRBOX.UTILS related FEATURE Feature request 🎞 WEBM RAWRBOX.WEBM related 🎺 BASS RAWRBOX.BASS related 🐲 SAMPLES Samples related 💼 RESOURCES RAWRBOX.RESOURCES related 📜 SCRIPTING RAWRBOX.SCRIPTING related 📷 RENDERER RAWRBOX.RENDERER related 🧙‍♂️ ASSIMP RAWRBOX.ASSIMP related 🧪 TESTS Tests related labels Aug 8, 2023
@github-actions github-actions bot added 🖼️ UI RAWRBOX.UI related 🧮 MATH RAWRBOX.MATH related labels Aug 8, 2023
@edunad edunad force-pushed the features/wrappers branch from a42d31d to d2b2273 Compare August 12, 2023 12:11
@github-actions github-actions bot added the 💽 ENGINE RAWRBOX.ENGINE related label Aug 15, 2023
@github-actions
Copy link

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy reports: 2 concern(s)
  • bass/src/sound/instance.cpp

    /bass/src/sound/instance.cpp:30:8: error: [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]

    Call to virtual method 'SoundInstance::isCreated' during destruction bypasses virtual dispatch

                    if (!this->isCreated()) return;
                         ^~~~~~~~~~~~~~~~~
    /runner/_work/rawrbox/rawrbox/bass/src/sound/instance.cpp:30:8: note: Call to virtual method 'SoundInstance::isCreated' during destruction bypasses virtual dispatch
                    if (!this->isCreated()) return;
                         ^~~~~~~~~~~~~~~~~
  • render/src/scripting/wrappers/light/manager_wrapper.cpp

    /render/src/scripting/wrappers/light/manager_wrapper.cpp:74:59: error: [misc-unused-parameters,-warnings-as-errors]

    parameter 'indx' is unused

            rawrbox::LightBaseWrapper LightsWrapper::getLight(size_t indx) {
                                                                     ^~~~
                                                                      /*indx*/

Have any feedback or feature suggestions? Share it here.

@edunad edunad merged commit 0b9ed43 into master Aug 16, 2023
@edunad edunad deleted the features/wrappers branch August 16, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧙‍♂️ ASSIMP RAWRBOX.ASSIMP related 🎺 BASS RAWRBOX.BASS related 💽 ENGINE RAWRBOX.ENGINE related FEATURE Feature request 🧮 MATH RAWRBOX.MATH related 📷 RENDERER RAWRBOX.RENDERER related 💼 RESOURCES RAWRBOX.RESOURCES related 🐲 SAMPLES Samples related 📜 SCRIPTING RAWRBOX.SCRIPTING related 🧪 TESTS Tests related 🖼️ UI RAWRBOX.UI related ⚒️ UTILS RAWRBOX.UTILS related 🎞 WEBM RAWRBOX.WEBM related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TODO] Add missing lua wrappers to packages
1 participant