Skip to content

Commit

Permalink
fix: reverted footer plugin to use simple footer (openedx#1047)
Browse files Browse the repository at this point in the history
  • Loading branch information
abdullahwaheed authored May 14, 2024
1 parent 0fc68f7 commit 40c6799
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 13 deletions.
14 changes: 4 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
],
"dependencies": {
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
"@edx/frontend-component-footer": "^13.2.0",
"@edx/frontend-component-footer": "13.1.0",
"@edx/frontend-component-header": "5.3.1",
"@edx/frontend-platform": "8.0.1",
"@edx/openedx-atlas": "^0.6.0",
Expand Down
5 changes: 3 additions & 2 deletions src/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import ReactDOM from 'react-dom';
import { Route, Routes, Outlet } from 'react-router-dom';

import Header from '@edx/frontend-component-header';
import { FooterSlot } from '@edx/frontend-component-footer';
// Reverting this since footer-edx overrite doesn't support FooterPlugin
import Footer from '@edx/frontend-component-footer';

import configureStore from './data/configureStore';
import AccountSettingsPage, { NotFoundPage } from './account-settings';
Expand All @@ -34,7 +35,7 @@ subscribe(APP_READY, () => {
<main className="flex-grow-1" id="main">
<Outlet />
</main>
<FooterSlot />
<Footer />
</div>
)}
>
Expand Down

0 comments on commit 40c6799

Please sign in to comment.