Add support for new SMTP config schema #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Dec 3, 2024
Comment on lines
58
to
59
| <span>Warning:</span> You have enabled auth providers | ||
| requiring email, but no SMTP provider is configured. |
There was a problem hiding this comment.
It's a bit more complicated than this since you might avoid configuring SMTP and just use webhooks.
There was a problem hiding this comment.
Now that I think of it, we should have an opt-out option which sets the pointer to {} without losing your config.
There was a problem hiding this comment.
Ok, I've updated the warnings to be more specific and also take into account webhook config. And added a button deselect the currently enabled smtp provider.
scotttrinh
reviewed
Dec 5, 2024
Comment on lines
+253
to
+255
| <span>Warning:</span> You have not entered a password. If there | ||
| is an existing password, it will be deleted when you update | ||
| this SMTP provider unless you re-enter the password above. |
| ); | ||
|
|
||
| return { | ||
| verificationNoSmtp: emailVerification && !smtpConfigured, |
There was a problem hiding this comment.
verification can be a webhook as well: EmailVerificationRequested
… event in the provider warning checks
scotttrinh
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new SMTP config introduced in edgedb/edgedb#7942.
@scotttrinh I'm not sure how the cloud magic smtp provider will be introspected, is it going to be a another type extending
cfg::EmailProviderthat won't be user configurable, or is it anotherSMTPProviderConfigwhich we have to make readonly in the UI?Also there's a new potential tripping hazard when updating an existing smtp provider, as I think we now have to update the whole config object, so that will reset the password every time unless you re-enter the password whenever you make a change.Disabled editing of smtp configs for now.Re-enabled smtp config editing, but with a warning message if you don't re-enter the password.