Upgrade quince #6
Conversation
package.json
Outdated
| @@ -53,6 +53,7 @@ | |||
| "react-redux": "7.2.9", | |||
| "react-router": "5.2.1", | |||
| "react-router-dom": "5.3.0", | |||
| "react-query": "^3.39.3", | |||
| @import "~@edx/brand/paragon/fonts.scss"; | ||
| @import "~@edx/brand/paragon/variables.scss"; | ||
| @import "~@edx/paragon/scss/core/core.scss"; | ||
| @import "~@edx/brand/paragon/overrides.scss"; | ||
| @import '~@edx/brand/paragon/fonts.scss'; | ||
| @import '~@edx/brand/paragon/variables.scss'; | ||
| @import '~@edx/paragon/scss/core/core.scss'; | ||
| @import '~@edx/brand/paragon/overrides.scss'; | ||
|
|
||
| $fa-font-path: "~font-awesome/fonts"; | ||
| @import "~font-awesome/scss/font-awesome"; | ||
| $fa-font-path: '~font-awesome/fonts'; | ||
| @import '~font-awesome/scss/font-awesome'; |
There was a problem hiding this comment.
Why make changes that are not necessary? This will make transition and blaming hard for later.
if they're using a linting config, kindly set your editor so follow those rules.
| <Header courseOrg={org} courseNumber={courseNumber} courseTitle={courseTitle} /> | ||
| <Header /> |
There was a problem hiding this comment.
Can't we just have our Header component show any text we pass to it? so we don't need to delete the data showing in the header?
There was a problem hiding this comment.
We don’t have a specific header for this MFE; we use a unique header for all MFEs. Here, they use the learning header, which has differences compared to the main header.
src/head/Head.jsx
Outdated
There was a problem hiding this comment.
And also, we have a header component for a reason, to not repeat ourselves. if we needed a change, we just updated the header component and it should be available everywhere. why do we have a Header component here?
milad-emami
force-pushed
the
upgrade-quince
branch
2 times, most recently
from
2d9b48b to
3ae18c7
Compare
milad-emami
force-pushed
the
upgrade-quince
branch
from
6d52f9f to
fe687f7
Compare
Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist