Fixes for NAG compiler #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
reviewed
Jun 17, 2024
| @@ -28,7 +28,7 @@ module fckit_shared_object_module | |||
| public :: fckit_c_deleter | |||
| public :: fckit_c_nodeleter | |||
| #if FCKIT_HAVE_ECKIT | |||
| public :: fckit_owned | |||
| public fckit_owned | |||
There was a problem hiding this comment.
This change is a debugging leftover ?
| @@ -25,8 +25,7 @@ module fckit_shared_ptr_module | |||
| #else | |||
| use fckit_refcount_module, only : & | |||
| & fckit_refcount, & | |||
| & fckit_refcount_interface, & | |||
| & fckit_external | |||
There was a problem hiding this comment.
The removal of fckit_external is strange. Is this required?
There was a problem hiding this comment.
No, I have added it back.
|
|
wdeconinck
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes seem to enable fckit to build with NAG and run most of the ctests. The changes fall into 3 categories:
This affects fckit_mpi.fypp, fckit_tensor.F90 and test_tensor.F90. The issue here is that there are variables being passed to array_view1d, a function that returns a point to that same variable. However this only works if the variable is declared with the target in the calling routine. I think NAG is correct here; in Fortran pointers can only point to variables with the target attribute; without the target attribute these pointers are in an undefined state.
NAG doesn't compile these as functions and I think it is a compiler bug. However turning them into subroutines works and doesn't seem to cause any knock-on problems.
These tests require building Fortran code but compile flags are needed for this to work. These changes do that.
What do you think? I don't think this has any downstream affects. The only possibility is if something outside of fckit is calling fckit_owned or fckit_external directly; I don't know of anything but maybe there is.