Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add earthkit-transforms #58

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Add earthkit-transforms #58

merged 5 commits into from
Aug 12, 2024

Conversation

EddyCMWF
Copy link
Collaborator

@EddyCMWF EddyCMWF commented Aug 5, 2024 •
edited
Loading

Add earthkit-transforms as a standard package

@FussyDuck
Copy link

FussyDuck commented Aug 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@EddyCMWF EddyCMWF requested review from sandorkertesz, iainrussell and jameshawkes and removed request for sandorkertesz and iainrussell August 5, 2024 10:45
@sandorkertesz
Copy link
Collaborator

@EddyCMWF
Please also update init.py and the tests. Consider renaming the issue to e.g. "Add earthkit-transforms".

@EddyCMWF EddyCMWF changed the title Update environment.yml Add earthkit-transforms Aug 5, 2024
@EddyCMWF
Copy link
Collaborator Author

EddyCMWF commented Aug 5, 2024

@EddyCMWF Please also update init.py and the tests. Consider renaming the issue to e.g. "Add earthkit-transforms".

done

@sandorkertesz
Copy link
Collaborator

Can it be merged now?

@iainrussell
Copy link
Member

I think so, I'm happy to do it if you give me the 'ok'

@sandorkertesz sandorkertesz merged commit 5734505 into develop Aug 12, 2024
81 checks passed
@sandorkertesz sandorkertesz deleted the earthkit-transforms-added-to-env branch August 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandorkertesz sandorkertesz sandorkertesz approved these changes

@jameshawkes jameshawkes Awaiting requested review from jameshawkes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EddyCMWF @FussyDuck @sandorkertesz @iainrussell @jameshawkes