Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct input file for general aerosol optics in IFS-style drivers #30

Open
wants to merge 7 commits into
base: v1.6.1-beta
Choose a base branch
from

Conversation

reuterbal
Copy link
Contributor

This is a patch to the 1.6.1-beta branch. I will file a similar one against master in the future.

I noticed that results differed with the 49r1 namelist file between the IFS-style drivers and the "default" ecrad driver, while being the same with the 47r3 namelist file.
I managed to trace this to a different aerosol data file being used, when general_aerosol_optics is active.

This PR contributes:

  • a fix to radiation_setup that chooses a different aerosol data file when general_aerosol_optics is active
  • a fix to radiation_setup that disables the call to DRY_AEROSOL_MASS_EXTINCTION, which fails with a segfault. Since the aerosol setup is already performed during the input reading, it is redundant in the standalone context anyway.
  • a build option that optionally allows to supply effective radii, seed and cloud fraction to RADIATION_SCHEME. This way we can ensure the same values are used per column, independent of the chosen block size, and thus obtain bit-identical results between blocked and non-blocked drivers.
  • an addition to the test specification in CMake that uses cdo (if available) to compare outputs between ifs-drivers and the non-ifs driver (with net flux output)

@reuterbal reuterbal requested a review from rjhogan January 15, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant