Naab JUBE patches workflow #87
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This arch is intended as a generic arch for systems with the following: - No slurm - Intel legacy and/or oneAPI compilers installed The intention is to provide a base for benchmarking systems.
This workflow is designed to test various git .patches on the same HEAD. This can be particularly useful when comparing multiple optimisations, or incremental improvements on the same optimisation. These patches must apply cleanly and successfully. The workflow is as follows: • git stash • git apply a patch • compile & benchmark • repeat until out of patches • git stash pop
This fixes two bugs: • A "blank" patch caused by a trailing comma • Incorrectly parsing the patches_dir, caused by the variable not being in include_parameterset.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a couple of changes one is a small addition of a "generic" arch, and the other is the JUBE patches workflow.
Generic Arch
This is a couple of arches, one for the Intel classic compilers and another for the new oneAPI suite. They are very similar to the ECMWF HPC2020 ones, but I've removed the module commands and hardware assumptions (vector ISAs etc). I find I often create these arches whenever I'm testing a new machine, and thought it was worth automating at least part of the process.
While they might not work out of the box for every machine, they're at least a good starting point for something minimalistic.
JUBE Patches Workflow
This is a new workflow for JUBE that consists of the following:
git stashgit applygit resetgit stash popAdditionally, the
git resetandgit stash popcommands are within atrapso as to never leave the source code in an inconsistent state.The main use case for this is investigating the effects of potential optimisations for CloudSC. "Does this change actually improve performance over the previous iteration?", "does it require nproma to be changed?", "what if these flags are changed?", etc. This workflow allows for such questions to be answered quickly, and preserves the changes without being as formal as a git commit, enabling quicker iteration for small "what ifs".
I personally use this workflow a lot and hope it will be of use to others too!