feat: use WSL in Windows for execution of OMNeT++ federate #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
branch issue number is wrong, should be 927, I hope you dont care :D |
hoelger
force-pushed
the
928-mixed-setup-omnet
branch
2 times, most recently
from
6d88aea to
1a74d1a
Compare
Was wrong anyways, because the ObjectInstantiation.readFile does fall back to default constructor if the file is not found
hoelger
force-pushed
the
928-mixed-setup-omnet
branch
from
1a74d1a to
a2c72e3
Compare
kschrab
requested changes
Nov 11, 2024
rti/mosaic-rti-api/src/main/java/org/eclipse/mosaic/rti/api/FederateAmbassador.java
Outdated
Show resolved
Hide resolved
...osaic-omnetpp/src/main/java/org/eclipse/mosaic/fed/omnetpp/ambassador/OmnetppAmbassador.java
Outdated
Show resolved
Hide resolved
fed/mosaic-sns/src/main/java/org/eclipse/mosaic/fed/sns/ambassador/SnsAmbassador.java
Show resolved
Hide resolved
...osaic-omnetpp/src/main/java/org/eclipse/mosaic/fed/omnetpp/ambassador/OmnetppAmbassador.java
Outdated
Show resolved
Hide resolved
|
logger.patch |
kschrab
requested changes
Nov 12, 2024
rti/mosaic-starter/src/main/java/org/eclipse/mosaic/starter/MosaicSimulation.java
Outdated
Show resolved
Hide resolved
rti/mosaic-rti-api/src/main/java/org/eclipse/mosaic/rti/api/FederateAmbassador.java
Outdated
Show resolved
Hide resolved
rti/mosaic-rti-api/src/main/java/org/eclipse/mosaic/rti/api/AbstractFederateAmbassador.java
Outdated
Show resolved
Hide resolved
kschrab
changed the title
hoelger
force-pushed
the
928-mixed-setup-omnet
branch
from
599972c to
4562166
Compare
kschrab
approved these changes
Nov 13, 2024
kschrab
approved these changes
Nov 18, 2024
schwepmo
pushed a commit
that referenced
this pull request
Dec 2, 2024
* feat: support win:mosaic-git together with wsl:omnet * fix: correctly log inside ObjectInstantiation * feat: throw error if omnetpp.ini file is missing * feat: throw error if ns3_federate_config.xml file is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can call wsl:omnet out of windows development
Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required? No
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer