API alignment: handler is always in options #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an misalignment between API handler/callback parameter:
callaback
parameter doesn't allow chanllel., it may/should support it in the future. Therefore parameter name should behandler
declare_subscriber
handler parameter was passed in arguments, while in other places it's passed in options. Made this uniform: now handler is always in options. (in fact this approach differs from the one in C++ which takes handler in parameters. But there is no function overloading in typescript, so approach with handler in options is better here)