CI workflow: fix relative cargo.toml path after gradle upgrade to 8.12 #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DariusIMP
added
bug
DariusIMP
changed the title
diogomatsubara
suggested changes
Jan 14, 2025
| @@ -208,7 +208,7 @@ fun buildZenohJNI(mode: BuildMode = BuildMode.DEBUG) { | |||
| } | |||
|
|
|||
| val result = project.exec { | |||
| commandLine(*(cargoCommand.toTypedArray()), "--manifest-path", "../zenoh-jni/Cargo.toml") | |||
| commandLine(*(cargoCommand.toTypedArray()), "--manifest-path", "./zenoh-jni/Cargo.toml") | |||
There was a problem hiding this comment.
There are a number of other places in the file that uses the relative path ../, shouldn't those be updated as well?
There was a problem hiding this comment.
Looks like CI passes with just the one change in the relative dir. I wonder if it might cause problems during release though
There was a problem hiding this comment.
I have double checked doing publications to maven local and the native libs are loaded properly. Seems that the Gradle upgrade issue only affects here when running a command this way using commandLine (which is a trick for automatically building the native library before building the packages). These changes should work fine.
milyin
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.