-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sync-toolchains workflow #3
Conversation
I kind of disagree to have a toolchain like that to run nightly and to automatically update the toolchain to the whole Rust project. I'd rather prefer to have a CI that can be triggered manually to sync all the repos to a specific rust toolchain version once we decide it's the right time to bump the toolchain. |
I can change the workflow to take a Rust version as input, it's a trivial change. However, this raises questions about how the Rust toolchain should be set.
This is why I sought to simplify all this by using the latest stable toolchain. Third parties can simply override the toolchain if they like (as long as they respect the MSRV). Moreover, crates.io ignores the toolchain altogether. Here's an example of what can go wrong:
Such an issue would be avoided by either:
|
@Mallets I updated the workflow to take the Rust toolchain version as an input. |
This pull request adds a workflow that fetches the latest stable Rust release, and updates all eclipse-zenoh Rust toolchains to use it. The workflow is scheduled to run nightly.