-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add workflow to bump and tag dev #157
feat: Add workflow to bump and tag dev #157
Conversation
Once we make a release, we can open the new development line. This workflow helps facilitate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags cannot be merged via pull requests. They need to be pushed directly into a branch. The tags pull be pushed to the repository in the tagging actions and scripts.
Previously I was trying to re-use the branch-bump-tag-crates.yml workflow but it's not possible within this context so use the actions directly
Enable all repos
run: bash ci/scripts/bump-and-tag.bash | ||
env: | ||
VERSION: ${{ inputs.version }} | ||
BUMP_DEPS_VERSION: ${{ inputs.version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bump-and-tag.bash
scripts don't have the same issue as the bump-crates
action. The branch would not be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we care? A PR will be created and the branch can be deleted after the PR is merged.
I tried this one out in a private branch and it failed. I'll go back to the drawing board. |
Once we make a release, we can open the new development line. This workflow helps facilitate that.