Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow to bump and tag dev #157

Conversation

diogomatsubara
Copy link
Contributor

Once we make a release, we can open the new development line. This workflow helps facilitate that.

Once we make a release, we can open the new development line. This
workflow helps facilitate that.
Copy link
Member

@fuzzypixelz fuzzypixelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags cannot be merged via pull requests. They need to be pushed directly into a branch. The tags pull be pushed to the repository in the tagging actions and scripts.

.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Show resolved Hide resolved
Previously I was trying to re-use the branch-bump-tag-crates.yml
workflow but it's not possible within this context so use the actions
directly
@diogomatsubara diogomatsubara marked this pull request as ready for review July 3, 2024 15:19
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Outdated Show resolved Hide resolved
run: bash ci/scripts/bump-and-tag.bash
env:
VERSION: ${{ inputs.version }}
BUMP_DEPS_VERSION: ${{ inputs.version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump-and-tag.bash scripts don't have the same issue as the bump-crates action. The branch would not be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we care? A PR will be created and the branch can be deleted after the PR is merged.

.github/workflows/bump-tag-dev.yml Show resolved Hide resolved
.github/workflows/bump-tag-dev.yml Show resolved Hide resolved
@diogomatsubara
Copy link
Contributor Author

I tried this one out in a private branch and it failed. I'll go back to the drawing board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants