Consume lemminx as a bundle from the OSGi runtime #1741
Conversation
|
Looks like build.properties needs some cleanup |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
1b57f8d to
7accb86
Compare
Done! |
|
and version needs a bump. |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
7accb86 to
867a101
Compare
Done! |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
867a101 to
26753a7
Compare
|
Looks like the test now needs an import-package. |
I fear this is due to the core.runtime bundle required and its insane re-exports of al system packages... |
If you can replace it with Import-Package, it'd be welcome. |
akurtakov
force-pushed
the
consume_lemminx_as_bundle
branch
from
26753a7 to
9df3359
Compare
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
9df3359 to
8f8d7e1
Compare
|
I now found this very useful preference in JDT: |
laeubi
force-pushed
the
consume_lemminx_as_bundle
branch
from
8f8d7e1 to
b5287e6
Compare
Currently lemminx is embedded into WWD what has some disadvantages: - the jar gets bigger - the embedded jar needs to be extracted before it can be used - version bumps are required for lemminx updates - lemminx can't be updated independent from WWD This now adds a require-bundle to the manifest (so we are getting a certain version we are compatible with) and uses the bundle wiring to get hold of the bundle and then transform it into a file path. Signed-off-by: Christoph Läubrich <[email protected]>
akurtakov
force-pushed
the
consume_lemminx_as_bundle
branch
from
b5287e6 to
add237d
Compare
|
@mickaelistria build is finally green! |
|
All that is extremely good! Please merge at your own convenience. |
Github says
and I'm not a committer on the project ;-) |
mickaelistria
merged commit b2b109e
into
eclipse-wildwebdeveloper:master
|
Thank you! |
|
Is there any planned release date that includes this fix? |
|
@vrubezhny Do you think you can produce a new release soon? |
Currently lemminx is embedded into WWD what has some disadvantages:
This now adds a require-bundle to the manifest (so we are getting a certain version we are compatible with) and uses the bundle wiring to get hold of the bundle and then transform it into a file path.
As discused here