Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IT test for Issue 4653 reproducer #4683

Closed
wants to merge 2 commits into from
Closed

IT test for Issue 4653 reproducer #4683

wants to merge 2 commits into from

Conversation

zladdi
Copy link
Contributor

@zladdi zladdi commented Feb 3, 2025

  • External dependency org.apache.commons:commons-lang3-${commons-lang3.version}.jar is downloaded and placed into target.eagerResolver/dependee/lib at build time using maven-dependency-plugin.
  • Please also review the naming of the project, naming and placement of the test class, and naming and placement of the other files and let me know if adjustments are requested.

@laeubi
Copy link
Member

laeubi commented Feb 3, 2025

@zladdi best is to always create PR on master, it can then be backported automatically.

@zladdi
Copy link
Contributor Author

zladdi commented Feb 3, 2025

@zladdi best is to always create PR on master, it can then be backported automatically.

Ok, will redo that then. Thanks for the hint.

@zladdi zladdi closed this Feb 3, 2025
@zladdi
Copy link
Contributor Author

zladdi commented Feb 3, 2025

Closed, will redo pull request based on main branch

@zladdi zladdi deleted the issue_4653_reproducer branch February 3, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zladdi @laeubi