Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider runbundles when computing dependencies #4682

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 3, 2025

If we have a bndrun activated then the runbundles become dependencies of the maven project.

This now calculates the enabled bndruns and return the bundle names so they can be used to add required reactor projects.

FYI @chrisrueger

If we have a bndrun activated then the runbundles become dependencies of
the maven project.

This now calculates the enabled bndruns and return the bundle names so
they can be used to add required reactor projects.
@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 3, 2025
@chrisrueger
Copy link
Contributor

I confirm this fixes our build and does not require the -testpath workaround anymore : 🎉

@laeubi laeubi enabled auto-merge (rebase) February 3, 2025 11:13
Copy link

github-actions bot commented Feb 3, 2025

Test Results

  606 files  ±0    606 suites  ±0   4h 4m 56s ⏱️ - 27m 35s
  434 tests ±0    426 ✅  - 1   7 💤 ±0  1 ❌ +1 
1 302 runs  ±0  1 279 ✅  - 1  22 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit eb1aa85. ± Comparison against base commit f5e7053.

@laeubi laeubi merged commit 807bd8e into eclipse-tycho:main Feb 3, 2025
14 of 16 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants