make synchronization of classpath calculation more fine-grained #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
reviewed
Feb 3, 2025
tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/OsgiBundleProject.java
Outdated
Show resolved
Hide resolved
andreas-schwarz-vector
force-pushed
the
main
branch
from
2f915d6 to
a56b657
Compare
laeubi
reviewed
Feb 3, 2025
tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/OsgiBundleProject.java
Outdated
Show resolved
Hide resolved
laeubi
added
the
backport-to-tycho-4.0.x
andreas-schwarz-vector
force-pushed
the
main
branch
2 times, most recently
from
74faa34 to
9562574
Compare
laeubi
reviewed
Feb 4, 2025
tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/OsgiBundleProject.java
Outdated
Show resolved
Hide resolved
tycho-core/src/main/java/org/eclipse/tycho/core/osgitools/OsgiBundleProject.java
Outdated
Show resolved
Hide resolved
Currently, the calculation of the classpath for a project is effectively a singleton because the BundleProject is used as monitor (synchronization). This leads to a poor performance if executing a tycho build with many threads, many projects and complex dependencies. This change replaces the global monitor with a fine-grained monitor the given project the classpath should be calculated for. This speeds up the parallel build.
laeubi
approved these changes
Feb 4, 2025
|
Thanks for your improvement propsals and for quickly processing this! 🙂 |
Test Results 606 files ±0 606 suites ±0 4h 25m 23s ⏱️ + 15m 11s For more details on these failures, see this check. Results for commit 3cfa93d. ± Comparison against base commit 18d50ba. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the calculation of the classpath for a project is effectively a singleton because the BundleProject is used as monitor (synchronization). This leads to a poor performance if executing a tycho build with many threads, many projects and complex dependencies.
This change replaces the global monitor with a fine-grained monitor the given project the classpath should be calculated for. This speeds up the parallel build.