Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let QuickFix run in UI, save editor, rebuild on error and wait for jobs #4641

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 25, 2025

Fixing one warning might make the resulting markers either invalid or no longer apply. Also quickfixes are often written to be run in the UI thread and might schedule jobs during execution.

This now rebuilds the project when one marker was fixed and run them in the UI while waiting for any jobs scheduled in the meantime.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Jan 25, 2025
@laeubi laeubi enabled auto-merge (rebase) January 25, 2025 07:30
Fixing one warning might make the resulting markers either invalid or no
longer apply. Also quickfixes are often written to be run in the UI
thread and might schedule jobs during execution.

This now rebuilds the project when one marker was fixed and run them in
the UI while waiting for any jobs scheduled in the meantime.
Copy link

Test Results

  606 files  ±0    606 suites  ±0   4h 5m 22s ⏱️ - 34m 45s
  434 tests ±0    426 ✅  - 1   7 💤 ±0  1 ❌ +1 
1 302 runs  ±0  1 279 ✅  - 1  22 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4d45953. ± Comparison against base commit a96b3e1.

@laeubi laeubi merged commit ab13859 into eclipse-tycho:main Jan 25, 2025
13 of 15 checks passed
@eclipse-tycho-bot
Copy link

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants