Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dr): Add DR about empty assetSelector validator #1774

Merged

Conversation

rafaelmag110
Copy link
Contributor

WHAT

Adds decision record about adding a validator to block contract definitions with empty asset selector.

WHY

Part of #1773. Please refer to that issue for more details.

@rafaelmag110 rafaelmag110 added the documentation Improvements or additions to documentation label Jan 30, 2025
Copy link
Contributor

@lgblaumeiser lgblaumeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this idea

Copy link
Contributor

@bmg13 bmg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a minor suggestion

Copy link

sonarqubecloud bot commented Feb 4, 2025

@rafaelmag110
Copy link
Contributor Author

@bmg13 @ndr-brt
Included your suggestions. Please give it a second look

@rafaelmag110 rafaelmag110 merged commit a8823f6 into eclipse-tractusx:main Feb 4, 2025
7 checks passed
@rafaelmag110 rafaelmag110 deleted the add_empty_selector_validation branch February 4, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants