common: Deprecate TraceCompassLogUtils and use trace-event-logger lib #207
+481
−658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickTasse
force-pushed
the
logutils
branch
2 times, most recently
from
4fa19d7 to
d05f6b8
Compare
Deprecate TraceCompassLogUtils and make its implementation defer all its work to LogUtils from the trace-event-logger library. Replace all use of TraceCompassLogUtils with LogUtils. Update all targets to include the trace-event-logger jar from Maven. Add trace-event-logger plug-in to RCP feature and releng-site. Signed-off-by: Patrick Tasse <[email protected]>
PatrickTasse
force-pushed
the
logutils
branch
from
d05f6b8 to
1f762a0
Compare
bhufmann
requested changes
Jan 27, 2025
| return this; | ||
| } | ||
|
|
||
| /** | ||
| * Set a category and ID for the flow scope. | ||
| * | ||
| * This method is mutually exclusive with | ||
| * {@link #setParentScope(FlowScopeLog)}. Calling both will throw an | ||
| * {@link #setParentScope(IFlowScopeLog)}. Calling both will throw an |
There was a problem hiding this comment.
This needs to be change to FlowScopeLog
| } | ||
|
|
||
| /** | ||
| * Set a category for the flow scope. When building the scope, an ID | ||
| * will be automatically generated. | ||
| * | ||
| * This method is mutually exclusive with | ||
| * {@link #setParentScope(FlowScopeLog)}. Calling both will throw an | ||
| * {@link #setParentScope(IFlowScopeLog)}. Calling both will throw an |
There was a problem hiding this comment.
This needs to be change to FlowScopeLog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Deprecate TraceCompassLogUtils and make its implementation defer all its
work to LogUtils from the trace-event-logger library.
Replace all use of TraceCompassLogUtils with LogUtils.
Update all targets to include the trace-event-logger jar from Maven.
Add trace-event-logger plug-in to RCP feature and releng-site.
How to test
Unit tests.
Follow-ups
N/A
Review checklist