Update node-pty to 1.1.0-beta27 #14677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14026 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
see microsoft/node-pty#751 Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder
force-pushed
the
14026_update_nodepty
branch
from
9dc3853 to
28b8c32
Compare
Signed-off-by: Thomas Mäder <[email protected]>
See https://github.com/eclipse-theia/theia/blob/master/doc/runtime-policy.md Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
msujew
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Seems to work pretty well. The changes to the tests are reasonable and everything works as expected on Windows and Ubuntu.
Since the tests pass, I would assume everything works on MacOS as well.
I've tried to see whether the update fixes #12733, but to no avail. Seems like the underlying issue still isn't fixed in node-pty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #14026
Closes #14342
Contributed on behalf of STMicroelectronics
How to test
Make sure terminals, and task functionalities still work.
Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers