Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ds/org.eclipse.pde.ds.core #1591

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 315a0eb80d3bd1776ebd59badb03956fb7884b1a Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Tue, 28 Jan 2025 13:50:17 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
index 25575270f4..3a0752f8c1 100644
--- a/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.ds.core;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ds.core.Activator
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.core.filebuffers;bundle-version="[3.3.0,4.0.0)",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

   285 files  ±0     285 suites  ±0   48m 27s ⏱️ - 5m 7s
 3 586 tests ±0   3 510 ✅ ±0   76 💤 ±0  0 ❌ ±0 
10 950 runs  ±0  10 719 ✅ ±0  231 💤 ±0  0 ❌ ±0 

Results for commit da90d0d. ± Comparison against base commit 13640dc.

@laeubi laeubi merged commit 9562fa2 into master Jan 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants